fix(eval): migrate pre-v2 workspace on eval label#13
Merged
Conversation
label_command read the workspace name from the trace and called gold.add directly, skipping ws_module.resolve() — the only path that runs the v2 schema migration. On a workspace whose db predates v2 (no gold_claim table) promotion crashed with "no such table". Resolve the workspace first so it migrates. Found running the feature live against a real pre-v2 workspace; the unit tests missed it because create() always builds the current schema. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found running the eval feature live:
orc eval labelread the workspace name from the trace and calledgold.adddirectly, skippingws_module.resolve()— the only path that runs the v2 schema migration. On a workspace whose db predates schema v2 (nogold_claimtable), promotion crashed withno such table: gold_claim.The unit tests missed it because
create()always builds the currentschema.sql(which has the table). The new regression test faithfully simulates a pre-v2 db by dropping the table and resetting the version stamp.Fix:
label_commandresolves the workspace first, triggering the migration.🤖 Generated with Claude Code